Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Integration tests for coder-cli #63

Closed
Russtopia opened this issue Jun 29, 2020 · 3 comments
Closed

Integration tests for coder-cli #63

Russtopia opened this issue Jun 29, 2020 · 3 comments
Assignees
@cmoog

Comments

@Russtopia
Copy link

As coder-cli runs against the backend (cdr/enterprise) and depends on its APIs, it would make sense to do some tests of the coder-cli tool itself as part of the main integration checks.

Major features could be tested to ensure they still function, eg:

  • sync
  • sh
  • devurls
    • add
    • update
    • list
    • delete
@Russtopia Russtopia changed the title Integration tests for coder-cli on enterprise CI pipeline Integration tests for coder-cli Jun 29, 2020
@wbobeirne
Copy link

I had also considered this in https://github.com/cdr/enterprise/issues/4230 (Probably should have opened the issue here.) Some upsides of having tests in enterprise is that:

  • We'll test changes as the API changes, so we can catch API breaks as a part of the PR in enterprise, instead of tests randomly break in here
  • We'll be able to re-use the data scaffolding code for frontend e2e tests, so that you can independently test each method instead of having to test CRUD as one whole flow

@Russtopia
Copy link
Author

I can close this one and move comments to #4230 if you'd prefer -- let me know, thanks

@cmoog cmoog self-assigned this Jul 28, 2020
This was referenced Jul 28, 2020
Merged
Merged
@cmoog
Copy link
Contributor

cmoog commented Jul 30, 2020

Closing as the coder-cli work is done. The remaining phases involve configuring enterprise namespace deployments and pointing the integrations tests towards mocked APIs.

@cmoog cmoog closed this as completed Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cmoog cmoog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbobeirne @Russtopia @cmoog