Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Running 'coder urls' without any arguments errors #82

Closed
scsmithr opened this issue Jul 30, 2020 · 2 comments · Fixed by #86
Closed

Running 'coder urls' without any arguments errors #82

scsmithr opened this issue Jul 30, 2020 · 2 comments · Fixed by #86
Labels
simple

Comments

@scsmithr
Copy link
Contributor 

> coder urls
2020-07-30 10:30:44 INFO	found ["work" "nathan" "hello" "commit-judge" "mydev" "nix"]
2020-07-30 10:30:44 FATAL	environment "" not found

We should instead check that the environment name isn't empty. If it is, we should print usage.
@cmoog
Copy link
Contributor

cmoog commented Jul 30, 2020 •
edited
Loading

We should also move this towards a more standard argument hierarchy of coder <resource> <verb> <identifier> <...flags>.

Something like

coder urls <env> ls <name>
coder urls <env> rm <name>
coder urls <env> create --name <name> --port <port>

@cmoog
Copy link
Contributor

cmoog commented Jul 30, 2020

Or... we could just move this to a subcommand of coder envs

@Russtopia Russtopia self-assigned this Aug 4, 2020
@cmoog cmoog mentioned this issue Aug 4, 2020
Merged
@Russtopia Russtopia removed their assignment Aug 4, 2020
@cmoog cmoog closed this as completed in #86 Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
simple
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to cobra coder/coder-v1-cli
3 participants
@Russtopia @scsmithr @cmoog