This repository was archived by the owner on Aug 30, 2024. It is now read-only.
added devurls capability #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
suggested changes
May 12, 2020
coadler
approved these changes
May 12, 2020
Comment on lines
+41
to
+42
| reqString := "%s/api/environments/%s/devurl?port=%s&session_token=%s" | ||
| reqUrl := fmt.Sprintf(reqString, entClient.BaseURL, env.ID, port, entClient.Token) |
There was a problem hiding this comment.
For re-usability I think it would make sense to have route constructors in their own function.
There was a problem hiding this comment.
I thought about that, but it's basically just Sprintf.
ammario
approved these changes
May 12, 2020
|
Code Climate has analyzed commit b695c20 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in getting coder-cli into environments.