This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Send stderr to ioutil.discard and log more human readable error #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
approved these changes
May 12, 2020
Co-authored-by: Ammar Bandukwala <ammar@ammar.io>
coadler
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The large block of text was caused by sending stderr -> stderr. I am sending it to ioutil.Discard. But, that does swallow some useful errors. For example, if you try to sync a directory that doesn't exist on the remote you get a helpful message alluding to such. The "error" itself is just exit status code 11.
It might be worth finding or creating a mapping of rsync exit status errors to human readable errors. Also, I'm not sure if different rsync versions will give the exact some error text.