This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Add new rich error messages #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
reviewed
Oct 21, 2020
| } | ||
|
|
||
| // LogInfo prints the given info message to stderr. | ||
| func LogInfo(header string, lines ...string) { |
There was a problem hiding this comment.
I'm a bit confused why LogInfo and LogSuccess are the only ones prefixed with Log
There was a problem hiding this comment.
Yeah this is definitely confusing. The issue I'm having is that Error, Warn, and Fatal return errors. So it would potentially be even more confusing for Info and Success to be the only ones with side-effects.
It gets pretty tricky when we actually do want to log errors as they happen: for example when iterating through a series of stop actions.
Any ideas?
There was a problem hiding this comment.
Ohh i see now, I was skimming over the returns. Considering the others return errors this makes more sense
coadler
approved these changes
Oct 21, 2020
- show rich log output for Info and Success logs - preserve rich CLI output for errors when possible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the
cargomessage formatting.