This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Show warning on coder-cli / Coder API version mismatch #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Oct 27, 2020
Comment on lines
+57
to
+61
| clog.Log(clog.Warn( | ||
| "version mismatch detected", | ||
| fmt.Sprintf("coder-cli version: %s", version.Version), | ||
| fmt.Sprintf("Coder API version: %s", apiVersion), clog.BlankLine, | ||
| clog.Tipf("download the appropriate version here: https://github.com/cdr/coder-cli/releases"), |
There was a problem hiding this comment.
Just to make sure, this is thrown to stderr correct?
There was a problem hiding this comment.
Yup, all log levels are thrown in stderr.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a warning to the user if the
<major>.<minor>versions do not match between the CLI and Coder API.Testing
Trying running a build generated from
./ci/steps/build.shand see that the version is injected and the warning hidden.