Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Unide envs (create|edit) commands #168

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Unide envs (create|edit) commands #168

merged 6 commits into from
Nov 4, 2020

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Nov 2, 2020

No description provided.

@cmoog cmoog marked this pull request as ready for review November 4, 2020 18:40
@cmoog cmoog requested a review from fuskovic November 4, 2020 20:03
@cmoog
Copy link
Contributor Author

cmoog commented Nov 4, 2020 •
edited
Loading

@fuskovic take a look at the integration tests that we've added as well to give some coverage to create|edit: https://github.com/cdr/coder-cli/blob/258f3e1bab8aa929c7ef0372cbdfaddc5b584d07/ci/integration/envs_test.go#L131

fuskovic
fuskovic approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@fuskovic fuskovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid cleanup before unhiding!

@cmoog cmoog merged commit b92aaf0 into master Nov 4, 2020
@cmoog cmoog deleted the unhide-create branch November 4, 2020 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fuskovic fuskovic fuskovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoog @fuskovic