Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Release action #182

Merged
merged 10 commits into from
Nov 11, 2020
Merged

Release action #182

merged 10 commits into from
Nov 11, 2020

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Nov 8, 2020

This PR adds a new Github Action workflow that runs whenever v* tags are pushed. It'll create a release build and upload the assets to a drafted Github release. This will still require that a human intervenes to make the release public and add any pertinent release notes.

@cmoog cmoog requested a review from coadler November 9, 2020 15:49
@cmoog cmoog marked this pull request as ready for review November 9, 2020 15:49
@cmoog cmoog requested a review from deansheather November 9, 2020 15:50
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a change to our enterprise release script so we avoid making two releases.

Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obv didn't test but LGTM if it works. I assume the draft release just shows up to repo admins and we can go in and publish?

@cmoog
Copy link
Contributor Author

cmoog commented Nov 9, 2020

I assume the draft release just shows up to repo admins and we can go in and publish?

Yup, exactly.

@cmoog cmoog merged commit 81537c5 into master Nov 11, 2020
@cmoog cmoog deleted the release-action branch November 11, 2020 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants