This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Implement coder images ls #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoog
suggested changes
Nov 16, 2020
| if outputFmt == jsonOutput { | ||
| enc := json.NewEncoder(os.Stdout) | ||
| // pretty print the json | ||
| enc.SetIndent("", "\t") |
cmoog
reviewed
Nov 16, 2020
|
I pushed up the suggested changes and updated the PR description to reflect the new human-readable output that includes the image tag now. If any of the command usage copy looks off or reads awkward, lmk what text you think we should have in its place. |
cmoog
approved these changes
Nov 16, 2020
3b2afa4 to
30126a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Allows users to list imported images.
By default, a
coder images lswill list every imported image for every organization a user belongs to.The default output is a human-readable table that describes the default resource amounts for each image :
Users can filter images by organization using the
--orgflag.Users may optionally choose to have the images output in a pretty-printed JSON format using
--output json.