This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Use env.ssh_available field in config-ssh #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
reviewed
Dec 3, 2020
e8ff634 to
f14f8ea
Compare
f14f8ea to
a32dfc5
Compare
cmoog
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Appreciate the cleanup 👍 . Looking at the failing integration test, I'd say the best course of action is to merge this as-is once https://github.com/cdr/c/pull/6108 is ready, then update the submodule in the cdr/c PR.
We can make sure the integration tests pass once master is deployed. We could also check that the integration passes when pointed at the cdrbot deployment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of dialing the SSH port to determine if SSH is available, uses a field exposed from cemanager in environments responses. This field has been added for the UI, but it makes sense to use it here too.
https://github.com/cdr/c/pull/6108