Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Use environment dictionary in config-ssh ux state call #199

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Dec 4, 2020

Context

https://github.com/cdr/c/pull/6095#issuecomment-738496271

cliSSHConfigured is changing data structure from bool -> map[string]bool in order to capture which environments are configured for SSH.

Progress

  • Download binary and run locally to test ux state

Context:

config-ssh needs to be re-ran when new environments are created.
Therefore the existing data structure assumption of cliSSHConfigured as
a boolean needs to be udpated to reflect environment identifiers.
@greyscaled greyscaled requested a review from cmoog December 4, 2020 05:59
@greyscaled greyscaled self-assigned this Dec 4, 2020
@greyscaled
Copy link
Contributor Author

Just ran locally ✔️

"ux_state": {
    "cliSSHConfigured": {
        "5ea9c439-eb239c3b0587c5e58f78416c": true,
        "5f149999-4ca3bd666994e2597d70fb61": true,
        "5fb0114b-91a81de17333a1f4d5819986": true
    }
}

Copy link
Contributor

@cmoog cmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid 👍

@greyscaled greyscaled merged commit 58320e4 into master Dec 4, 2020
@greyscaled greyscaled deleted the vapurrmaid/ch2889/config-ssh-uxs-2 branch December 4, 2020 06:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants