Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Add cvm flag to CLI and fields to coder-sdk #201

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Add cvm flag to CLI and fields to coder-sdk #201

merged 4 commits into from
Dec 9, 2020

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Dec 5, 2020

[ch4260]

@cmoog cmoog requested a review from kylecarbs December 5, 2020 21:20
@cmoog
Copy link
Contributor Author

cmoog commented Dec 5, 2020

--not-container-vm is pretty bad so please note if you have a better alternative.

@cmoog cmoog requested a review from fuskovic December 5, 2020 21:37
@kylecarbs
Copy link
Member

Thoughts on just --container?

fuskovic
fuskovic suggested changes Dec 6, 2020
View reviewed changes
@cmoog cmoog marked this pull request as ready for review December 6, 2020 04:12
@cmoog
Copy link
Contributor Author

cmoog commented Dec 6, 2020 •
edited
Loading

Thoughts on just --container?

@kylecarbs
For some reason container feels like a subset of conainter-vm, making it potentially confusing as a negator.

@kylecarbs
Copy link
Member

Fair. Maybe just --container and --vm then?

Honestly --container and --cvm isn't bad either.

@kylecarbs
Copy link
Member

Whats the news here moogman?

@cmoog
Copy link
Contributor Author

cmoog commented Dec 7, 2020

Thought I would just mull it over. The relationship between --container and --cvm is still confusing to me.

@kylecarbs
Copy link
Member

definitely fair

@cmoog cmoog requested a review from fuskovic December 8, 2020 04:05
@cmoog cmoog merged commit 9b94c77 into master Dec 9, 2020
@cmoog cmoog deleted the cvm-flag branch December 9, 2020 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fuskovic fuskovic fuskovic approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmoog @kylecarbs @fuskovic