Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Add cvm flag to CLI and fields to coder-sdk #201

Merged
merged 4 commits into from
Dec 9, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Add cvm flag to CLI and fields to coder-sdk
  • Loading branch information
cmoog committed Dec 5, 2020
commit a455cb80017ff4378787078e151049fad816ceb4
16 changes: 9 additions & 7 deletions coder-sdk/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@ type Client struct {

// newHTTPClient creates a default underlying http client and sets the auth cookie.
//
// NOTE: As we do not specify a custom transport, the default one from the stdlib will be used,
// resulting in a persistent connection pool.
// We do not set a timeout here as it could cause issue with the websocket.
// The caller is expected to set it when needed.
// NOTE:
// As we do not specify a custom transport, the default one from the stdlib will be used,
// resulting in a persistent connection pool.
// We do not set a timeout here as it could cause issue with the websocket.
// The caller is expected to set it when needed.
//
// WARNING: If the caller sets a custom transport to set TLS settings or a custom CA, the default
// pool will not be used and it might result in a new dns lookup/tls session/socket begin
// established each time.
// WARNING:
// If the caller sets a custom transport to set TLS settings or a custom CA the default
// pool will not be used and it might result in a new dns lookup/tls session/socket begin
// established each time.
func (c Client) newHTTPClient() (*http.Client, error) {
jar, err := cookiejar.New(nil)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/envs.go
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func editEnvCmd(user *string) *cobra.Command {
gpus int
follow bool
useCVM bool
notCVM bool
notCVM bool
)

cmd := &cobra.Command{
Expand Down