This repository was archived by the owner on Aug 30, 2024. It is now read-only.
chore: sort coder envs by name in ssh config #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoog
approved these changes
Mar 2, 2021
internal/cmd/configssh.go
Outdated
| @@ -176,6 +177,9 @@ func writeSSHKey(ctx context.Context, client coder.Client, privateKeyPath string | |||
|
|
|||
| func makeNewConfigs(userName string, envs []coderutil.EnvWithWorkspaceProvider, privateKeyFilepath string) string { | |||
| newConfig := fmt.Sprintf("\n%s\n%s\n\n", sshStartToken, sshStartMessage) | |||
|
|
|||
| sort.Sort(coderutil.EWPsByEnvName(envs)) | |||
There was a problem hiding this comment.
personally, I much prefer sort.Slice but your call
There was a problem hiding this comment.
Ah.
Good call.
I like that better here too actually 👌
Thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.