Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

feature: support filtering by workspace provider when listing environ… #282

Merged
merged 6 commits into from
Mar 11, 2021
Merged

feature: support filtering by workspace provider when listing environ… #282

merged 6 commits into from
Mar 11, 2021

Conversation

fuskovic
Copy link
Contributor

@fuskovic fuskovic commented Mar 11, 2021 •
edited
Loading

What this does?

Adds the --provider flag to both the coder envs ls command as well as the coder resources top command.

envs command

Now supports the --provider flag so users can filter environments by a particular workspace provider name.

Screenshot 2021-03-11 at 3 22 46 PM

resource manager command

Now supports the --provider flag so users can aggregate resource amounts by a particular workspace provider name.

Screenshot 2021-03-11 at 3 52 41 PM

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #7505: As an admin, I want to be able to filter workspaces by the workspace provider they're using so that I can easily find and delete them and remove my workspace provider quickly.

@fuskovic fuskovic force-pushed the faris/ch7505/add-provider-flag-to-coder-envs-ls branch from ee4b8c7 to e9874ea Compare March 11, 2021 15:50
cmoog
cmoog reviewed Mar 11, 2021
View reviewed changes
cmoog
cmoog reviewed Mar 11, 2021
View reviewed changes
@fuskovic fuskovic requested a review from cmoog March 11, 2021 19:50
@cmoog
Copy link
Contributor

cmoog commented Mar 11, 2021

So I'm having second thoughts about this design. In all other cases coder envs ls only lists environments owned by the active user. I think this functionality should be rolled under the coder resources subcommand where the use case more closely matches.

cmoog
cmoog approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@cmoog cmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff. looks good to go

@fuskovic fuskovic merged commit a7a7b37 into master Mar 11, 2021
@fuskovic fuskovic deleted the faris/ch7505/add-provider-flag-to-coder-envs-ls branch March 11, 2021 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmoog cmoog cmoog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuskovic @cmoog