Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

chore: cleanup TODO comments #284

Merged
merged 1 commit into from
Mar 11, 2021
Merged

chore: cleanup TODO comments #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ci/integration/tags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,5 @@ func TestTags(t *testing.T) {
tcli.StdoutJSONUnmarshal(&tags),
)
assert.True(t, "> 0 tags", len(tags) > 0)

// TODO(@cmoog) add create and rm integration tests
})
}
2 changes: 1 addition & 1 deletion internal/cmd/rebuild.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func trailBuildLogs(ctx context.Context, client coder.Client, envID string) erro
s.Start()

case coder.BuildLogTypeSubstage:
// TODO(@cmoog) add verbose substage printing
// TODO(@f0ssel) add verbose substage printing
if !verbose {
continue
}
Expand Down
6 changes: 0 additions & 6 deletions internal/cmd/resourcemanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,12 +310,6 @@ func (a resources) String() string {
"[cpu: alloc=%.1fvCPU]\t[mem: alloc=%.1fGB]",
a.cpuAllocation, a.memAllocation,
)

// TODO@cmoog: consider adding the utilization info once a historical average is considered or implemented
// return fmt.Sprintf(
// "[cpu: alloc=%.1fvCPU, util=%s]\t[mem: alloc=%.1fGB, util=%s]",
// a.cpuAllocation, a.cpuUtilPercentage(), a.memAllocation, a.memUtilPercentage(),
// )
}

//nolint:unused
Expand Down