feat: replace `coder sh` implementation to shell out to `ssh` #292

cmoog · 2021-03-17T16:24:31Z

Previously, we used our custom WebSocket shell protocol
to open shells with coder sh. This divergent behavior
from genuine SSH created confusion and a lack of feature parity
between the two connection methods.

Previously, we used our custom websocket shell protocol to open shells with `coder sh`. This divergent behavior from genuine SSH creates confusion and lack of feature parity between the two connection methods.

internal/cmd/cmd.go

jawnsy · 2021-03-17T16:27:17Z

Is this going to affect dependencies required on Windows? I think Linux and Mac machines often include OpenSSH clients, but the same is not true on Windows. I'm on my phone right now but will take a deeper look later

deansheather · 2021-03-17T16:31:25Z

@jawnsy windows 10 has openssh installed by default now

cmoog · 2021-03-17T16:56:33Z

Obviously as follow-ups we could add flag behavior similar to gcloud compute ssh...

ERROR: (gcloud.compute.ssh) argument [USER@]INSTANCE: Must be specified.
Usage: gcloud compute ssh [USER@]INSTANCE [optional flags] [-- SSH_ARGS ...]
  optional flags may be  --command | --container | --dry-run |
                         --force-key-file-overwrite | --help | --internal-ip |
                         --plain | --ssh-flag | --ssh-key-expiration |
                         --ssh-key-expire-after | --ssh-key-file |
                         --strict-host-key-checking | --tunnel-through-iap |
                         --zone

For detailed information on this command and its flags, run:
  gcloud compute ssh --help

gonna swap you out for jon since he has the customer context here as well

sreya · 2021-03-17T17:57:29Z

internal/cmd/ssh.go

+		Args:  shValidArgs,
+		Example: `coder ssh my-dev
+coder ssh my-dev pwd`,
+		Aliases:               []string{"sh"},


feat: replace coder sh implementation to shell out to ssh

3c8f0dc

Previously, we used our custom websocket shell protocol to open shells with `coder sh`. This divergent behavior from genuine SSH creates confusion and lack of feature parity between the two connection methods.

cmoog requested review from jawnsy and deansheather March 17, 2021 16:24

deansheather previously requested changes Mar 17, 2021

View reviewed changes

internal/cmd/cmd.go Show resolved Hide resolved

cmoog added 2 commits March 17, 2021 11:41

fixup! feat: replace coder sh implementation to shell out to ssh

672ce07

fixup! feat: replace coder sh implementation to shell out to ssh

3852a24

cmoog marked this pull request as ready for review March 17, 2021 16:47

cmoog added 2 commits March 17, 2021 11:50

fixup! feat: replace coder sh implementation to shell out to ssh

b2565f8

fixup! feat: replace coder sh implementation to shell out to ssh

e05a6f3

cmoog requested a review from sreya March 17, 2021 17:34

sreya approved these changes Mar 17, 2021

View reviewed changes

internal/cmd/ssh.go

Args: shValidArgs,

Example: `coder ssh my-dev

coder ssh my-dev pwd`,

Aliases: []string{"sh"},

Copy link

Collaborator

sreya Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cmoog merged commit 61fa5ad into master Mar 17, 2021

cmoog deleted the cmoog/cleanup-sh branch March 17, 2021 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace `coder sh` implementation to shell out to `ssh` #292

feat: replace `coder sh` implementation to shell out to `ssh` #292

cmoog commented Mar 17, 2021

jawnsy commented Mar 17, 2021

deansheather commented Mar 17, 2021

cmoog commented Mar 17, 2021

sreya Mar 17, 2021

feat: replace coder sh implementation to shell out to ssh #292

feat: replace coder sh implementation to shell out to ssh #292

Conversation

cmoog commented Mar 17, 2021

jawnsy commented Mar 17, 2021

deansheather commented Mar 17, 2021

cmoog commented Mar 17, 2021

sreya Mar 17, 2021

Choose a reason for hiding this comment

feat: replace `coder sh` implementation to shell out to `ssh` #292

feat: replace `coder sh` implementation to shell out to `ssh` #292