This repository was archived by the owner on Aug 30, 2024. It is now read-only.
chore: migrate more tests from tcli to in-mem #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuskovic
approved these changes
Mar 22, 2021
| } | ||
| if org == nil { | ||
| slogtest.Fatal(t, "failed to find org of current user") | ||
| return // help the linter out a bit |
There was a problem hiding this comment.
Seems strange to have a return after a fatal but I guess there's something going on with the linter that's not obvious to me. The comment doesn't help explain why so I think we can just elaborate on the comment or just add a nolint. Either way no big deal just my general thoughts reading.
| @@ -146,6 +146,10 @@ func execute(t *testing.T, in io.Reader, args ...string) result { | |||
| cmd.SetOut(&outStream) | |||
| cmd.SetErr(&errStream) | |||
|
|
|||
| // TODO: this *needs* to be moved to function scoped writer arg. As is, | |||
| // this prevents tests from running in parallel. | |||
Co-authored-by: Faris Huskovic <faris@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.