This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Centralize p2p Dial logic #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3545f94 to
edbbb9c
Compare
kylecarbs
suggested changes
Apr 28, 2021
aef2996 to
c7af0e9
Compare
kylecarbs
reviewed
Apr 28, 2021
kylecarbs
reviewed
Apr 28, 2021
101a2f7 to
70116ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a WorkspaceClient that can dial workspaces and represent data channels as net.Conns. With this abstraction we can dial wsep commands over these connections, which is my next step.