Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Rename environments to workspaces and use new routes #350

Merged
merged 6 commits into from
May 14, 2021
Merged

Rename environments to workspaces and use new routes #350

merged 6 commits into from
May 14, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented May 13, 2021 •
edited
Loading

Also closes [ch5518].

code-asher added 4 commits May 13, 2021 15:50
@code-asher
Rename env types to workspace
4161a09
@code-asher
Rename envs sub-command to ws
a42c757 
Aliases are `envs` and `workspaces`.
@code-asher
Rename files from env to workspace
24ab3d2
@code-asher
Add a deprecated envs command
4f141bc 
There doesn't appear to be a way to deprecate an alias so create a new
command instead.
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #5567: Deprecate envs subcommand in coder-cli.

@code-asher code-asher requested a review from f0ssel May 13, 2021 21:04
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #5518: Rename endpoints/types in coder-sdk.

f0ssel
f0ssel approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has anyone else been looped in on the command change from coder envs to coder ws? I know we have been using that shorthand internally but since this is an customer command I'd wanna make sure others are on board. I don't hate workspaces but I do see it's long.

@f0ssel f0ssel requested a review from kylecarbs May 13, 2021 21:51
@kylecarbs
Copy link
Member

We should do both workspaces and ws imo.

@code-asher
Copy link
Member Author

Currently I have workspaces as an alias for ws but I think the reverse might actually make more sense.

@code-asher code-asher force-pushed the code-asher/ch5567 branch from b77eda1 to 5a1e017 Compare May 14, 2021 17:37
@code-asher
Copy link
Member Author

Swapped! We use workspaces everywhere now including documentation but ws is a valid alias to use in its place. I think this is quite a bit more clear especially since ws often means websocket, at least in the codebase.

@code-asher code-asher requested a review from f0ssel May 14, 2021 17:43
@kylecarbs
Copy link
Member

✨

f0ssel
f0ssel approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@code-asher code-asher merged commit 56ffab3 into master May 14, 2021
@code-asher code-asher deleted the code-asher/ch5567 branch May 14, 2021 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

1 more reviewer

@f0ssel f0ssel f0ssel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@code-asher @kylecarbs @f0ssel