Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

fix: Drop port when creating TURN endpoint #352

Merged
merged 1 commit into from
May 17, 2021
Merged

fix: Drop port when creating TURN endpoint #352

merged 1 commit into from
May 17, 2021

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented May 17, 2021 •
edited
Loading

Caused strings like localhost:5349:8080 when a hostname contained a port.

@kylecarbs kylecarbs requested a review from f0ssel May 17, 2021 22:35
f0ssel
f0ssel approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL there is a difference

@kylecarbs kylecarbs enabled auto-merge (squash) May 17, 2021 22:39
@kylecarbs kylecarbs merged commit 188450b into master May 17, 2021
@kylecarbs kylecarbs deleted the fixport branch May 17, 2021 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f0ssel f0ssel f0ssel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @f0ssel