Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Add logs to wsnet listener #388

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Add logs to wsnet listener #388

merged 4 commits into from
Jul 20, 2021

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Jul 16, 2021 •
edited
Loading

TODO:

  • Add logger
  • Log:
    • Startup
    • Handshake WS connect
    • Handshake WS stream opened in yamux
    • ICE candidates received (and contents)
    • Sending ICE candidates (and contents)
    • Connection state changes
    • Timeouts/ping failures

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #15087: Make "coder agent" log stuff.

@deansheather deansheather marked this pull request as ready for review July 20, 2021 02:32
@deansheather deansheather requested review from kylecarbs and f0ssel and removed request for kylecarbs July 20, 2021 02:32
@deansheather deansheather enabled auto-merge (squash) July 20, 2021 02:33
f0ssel
f0ssel approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we current run the agent with debug enabled? We should if not at least for initial release

@deansheather deansheather merged commit 4de99d5 into master Jul 20, 2021
@deansheather deansheather deleted the dean/ch15087 branch July 20, 2021 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f0ssel f0ssel f0ssel approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @f0ssel