Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

feat: Display error to user when SSHing into offline workspace #411

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Aug 9, 2021

Very fun lil hack to display user output on an SSH connection to offline workspaces.

image

Here's what it looks like from VS Code:

image

@kylecarbs kylecarbs requested a review from jawnsy August 9, 2021 07:49
@kylecarbs
Copy link
Member Author

[ch15894]

@shortcut-integration
Copy link

@kylecarbs kylecarbs changed the title feat: Display error to user when SSH'ing into offline workspace feat: Display error to user when SSHing into offline workspace Aug 9, 2021
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! what was the error message before?

Co-authored-by: Jonathan Yu <jonathan@coder.com>
@kylecarbs
Copy link
Member Author

A context deadline exceeded 🤕 It'd attempt to connect and exchange candidates but since a workspace wasn't listening nothing would happen!

@kylecarbs kylecarbs enabled auto-merge (squash) August 9, 2021 16:53
@kylecarbs kylecarbs merged commit 3536869 into master Aug 9, 2021
@kylecarbs kylecarbs deleted the sshoff branch August 9, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants