Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

fixup! fix: cmd/update: do not use NewStrictVersion for user-provided… #442

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fixup! fix: cmd/update: do not use NewStrictVersion for user-provided… #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions internal/cmd/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,15 +412,6 @@ func Test_getDesiredVersion(t *testing.T) {
assert.Success(t, "error should be nil", err)
assert.True(t, "should handle versions without trailing zero", expected.Equal(actual))
})

t.Run("empty coder URL", func(t *testing.T) {
t.Parallel()

expected := &semver.Version{}
actual, err := getDesiredVersion(nil, "", "")
assert.ErrorContains(t, "error should be nil", err, "get coder url")
assert.True(t, "should handle versions without trailing zero", expected.Equal(actual))
})
}

// fakeGetter mocks HTTP requests.
Expand Down