-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
e7d80a4
to
b76e49d
Compare
b76e49d
to
1051d46
Compare
1051d46
to
6b95234
Compare
6b95234
to
24c98cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one request was addressed, ty sir 🙏
0a79ef7
to
22bffe8
Compare
Desc: "get all development urls for external access", | ||
Name: "create", | ||
Usage: "<env name> <port> [--a access]", | ||
Desc: "create/update a devurl for external access", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it just --a, do you want it fully-spelled out ie., --access ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer --acess
for the flag. If you also want the -a
shorthand, we could use fl.StringVarP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments, feel free to merge when addressed.
Desc: "get all development urls for external access", | ||
Name: "create", | ||
Usage: "<env name> <port> [--a access]", | ||
Desc: "create/update a devurl for external access", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer --acess
for the flag. If you also want the -a
shorthand, we could use fl.StringVarP
22bffe8
to
4f09af1
Compare
This implements the new subcommands proposed in #57
Example Usage