Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Add github action to build releases #68

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add github action to build releases #68

merged 1 commit into from
Jul 1, 2020

Conversation

scsmithr
Copy link
Contributor

@scsmithr scsmithr commented Jul 1, 2020 •
edited
Loading

Fixes #62

@scsmithr scsmithr force-pushed the github-build-action branch 2 times, most recently from fe174b1 to ac701b2 Compare July 1, 2020 18:52
@scsmithr scsmithr marked this pull request as ready for review July 1, 2020 18:57
@scsmithr scsmithr requested a review from nathanpotter July 1, 2020 18:57
ammario
ammario suggested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s just open source wsep

It’s privacy is an impediment to contribution

No prettying is necessary immediately

@scsmithr
Copy link
Contributor Author

scsmithr commented Jul 1, 2020

Sounds good to me, I was proud of my deploy key jank though.

@ammario
Copy link
Member

ammario commented Jul 1, 2020

We all are. That’s what made my comment so hard to write...

@scsmithr scsmithr force-pushed the github-build-action branch from abeb979 to 929cad0 Compare July 1, 2020 21:13
@scsmithr scsmithr merged commit 9b58d37 into master Jul 1, 2020
@cmoog cmoog deleted the github-build-action branch July 29, 2020 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario requested changes

@nathanpotter nathanpotter Awaiting requested review from nathanpotter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use github actions to build mac release binaries
2 participants
@scsmithr @ammario