Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Add custom prefix devurl #74

Merged
merged 7 commits into from
Aug 4, 2020
Merged

Add custom prefix devurl #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d92778
Add custom prefix devurl
Jul 30, 2020
11f797a
Reverted err response
Jul 30, 2020
362ddc7
Enabled error response JSON body output
Jul 30, 2020
c71c3c9
Add urls ls subcmd; add -o [human | json] support matching users cmd
Jul 30, 2020
cc55a4a
Add future support for integration devurl tests
Jul 30, 2020
f50cfc0
Merge branch 'master' into 4411-coder-cli-named-devurls
Jul 31, 2020
1dc6c3b
use requireSuccess(); log.Fatal() where appropriate; change 'del' to …
Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enabled error response JSON body output
  • Loading branch information
Russtopia committed Jul 30, 2020
commit 362ddc7cab9256c9574b61d82fe8b7c165dcf90a
3 changes: 3 additions & 0 deletions internal/entclient/devurl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ func (c Client) DelDevURL(envID, urlID string) error {
if err != nil {
return err
}
defer res.Body.Close()

if res.StatusCode != http.StatusOK {
return bodyError(res)
Expand Down Expand Up @@ -51,6 +52,7 @@ func (c Client) InsertDevURL(envID string, port int, name, access string) error
if err != nil {
return err
}
defer res.Body.Close()

if res.StatusCode != http.StatusOK {
return bodyError(res)
Expand Down Expand Up @@ -80,6 +82,7 @@ func (c Client) UpdateDevURL(envID, urlID string, port int, name, access string)
if err != nil {
return err
}
defer res.Body.Close()

if res.StatusCode != http.StatusOK {
return bodyError(res)
Expand Down
2 changes: 1 addition & 1 deletion internal/entclient/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

func bodyError(resp *http.Response) error {
byt, err := httputil.DumpResponse(resp, false)
byt, err := httputil.DumpResponse(resp, true)
if err != nil {
return xerrors.Errorf("dump response: %w", err)
}
Expand Down