This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Use release binary in integration tests #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff685cb to
318e09e
Compare
coadler
reviewed
Aug 22, 2020
| cmd := exec.Command( | ||
| "sh", "-c", | ||
| fmt.Sprintf("cd ../../ && go build -o %s ./cmd/coder", path), | ||
| fmt.Sprintf( | ||
| "cd ../../ && mkdir -p %s && ./ci/steps/build.sh && cp ./ci/bin/%s %s/ && tar -xzf %s -C %s", |
There was a problem hiding this comment.
What if you just pulled the go build command into its own function and source it so you can call it? Would remove the step of tar -> untar
There was a problem hiding this comment.
I'd prefer it to use as close to the actual release artifact as possible. Maybe that's not particularly rational in this case but the aim of this test is to prevent the previous regression from going undetected.
coadler
approved these changes
Aug 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://slab.coder.com/posts/regression-report-1-sr2qmy80