Skip to content

Add deploy cli [WIP] #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 24, 2021
Merged

Add deploy cli [WIP] #59

merged 14 commits into from
Aug 24, 2021

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Aug 19, 2021 •
edited
Loading

After talking with @bpmct about how we could make code-server easier to install for our users, I came up with the idea to create a CLI for code-server. My first idea is to implement a deploy command like code-server deploy. I made a POC, and here is the DEMO video if you are interested. I would love to hear your feedback and thoughts.
https://www.loom.com/share/b29513055f874db8a6e41bbf94455d71

What needs to be done:

  • Add the build script pos install
  • Improve the copy if it is needed
  • Add some automated tests, at least on the basic functionalities
  • Add Prettier and ESLint

@BrunoQuaresma BrunoQuaresma self-assigned this Aug 19, 2021
@BrunoQuaresma BrunoQuaresma requested review from bpmct and jsjoeio August 19, 2021 13:06
@bpmct
Copy link
Member

bpmct commented Aug 23, 2021

Add the build script pos install

What do you mean by this? Like another script to run after it is installed?

Improve the copy if it is needed

I think providing a link to generate a DigitalOcean Token (https://cloud.digitalocean.com/account/api/tokens) or we can even shorten, would help.

@bpmct
Copy link
Member

bpmct commented Aug 23, 2021

I'd love to ship something like this and write a blog post on it. Being able to customize the server name and region would also be 👌🏼

I'm happy to explore this, commander is an awesome library :)

@bpmct
Copy link
Member

bpmct commented Aug 23, 2021 •
edited
Loading

I also noticed this just hangs for me... Any idea why?

Screen Shot 2021-08-23 at 10 03 29 AM

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Aug 23, 2021 •
edited
Loading

What do you mean by this? Like another script to run after it is installed?

  • Yes, so we don't have to commit and push the build files.

I think providing a link to generate a DigitalOcean Token

  • Definitely, it is a good thing

I also noticed this just hangs for me... Any idea why?

  • It is happening because the actions are async. we have to check how to fix that 🤔

I'm happy to explore this

  • Feel free to make the changes that you want. I can also help with that

jsjoeio
jsjoeio approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @BrunoQuaresma 👏

A couple nits, but all non-blocking

cli/README.md
## Development

```console
git clone git@github.com:cdr/deploy-code-server.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is it standard to use the SSH URL instead of HTTPS? I feel like HTTPS is more common, at least from what I see in OSS.

cli/README.md
@@ -0,0 +1,14 @@
# dcs-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not super obvious what dcs stands for. maybe we should spell it out below "Deploy code-server (dcs)"

@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review August 24, 2021 13:28
@BrunoQuaresma
Copy link
Collaborator Author

@bpmct @jsjoeio I publish it to test the release process, and you can run it on npx:

npx @coder/deploy-code-server

I think we can add the following features for a 0.2.0 version of the CLI:

  • Option to chose the region
  • Option to chose the machine type
  • Import the SSH key

Thoughts?

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 24, 2021

@bpmct @jsjoeio I publish it to test the release process, and you can run it on npx:

npx @coder/deploy-code-server

I think we can add the following features for a 0.2.0 version of the CLI:

  • Option to chose the region
  • Option to chose the machine type
  • Import the SSH key

Thoughts?

Amazing! Dude you shipped that so quick 🔥 I'll remember to share this with the next code-server release!

Those features for 0.2.0 sound great to me! I imagine they're not too difficult.

@BrunoQuaresma BrunoQuaresma merged commit 0cedc14 into main Aug 24, 2021
@BrunoQuaresma BrunoQuaresma deleted the add-cli branch August 24, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @bpmct @jsjoeio