Skip to content

chore: refactor aws eks install page - reduce nodes, make ubuntu default #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 15, 2022
Merged

chore: refactor aws eks install page - reduce nodes, make ubuntu default #1077

merged 5 commits into from
Aug 15, 2022

Conversation

sharkymark
Copy link
Contributor

This is PR:

  1. Moves a lot of scary info down below about node requirements, prerequisite steps - they are still linked at the top
  2. replace the eksctl flag argument approach with a config yaml file for better readability
  3. remove step for storage class deletion, recreation - I tested, not needed
  4. remove 2nd node group creation - the first cluster and node group should be ubuntu to cover CVM use cases too
  5. add a cluster delete step
  6. general cleanup

My goal is to build an Azure AKS cluster and simplify too.

These steps will be ported and tweaked for OSS once helm is mature so I want to clean old tech debt out of here.

@sharkymark sharkymark requested a review from ericpaulsen August 14, 2022 20:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2022 •
edited
Loading

✨ Coder.com for PR #1077 deployed! It will be updated on every commit.

johnstcn
johnstcn reviewed Aug 15, 2022
View reviewed changes
johnstcn
johnstcn reviewed Aug 15, 2022
View reviewed changes
johnstcn
johnstcn reviewed Aug 15, 2022
View reviewed changes
johnstcn
johnstcn reviewed Aug 15, 2022
View reviewed changes
johnstcn
johnstcn reviewed Aug 15, 2022
View reviewed changes
johnstcn
johnstcn reviewed Aug 15, 2022
View reviewed changes
johnstcn
johnstcn approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some suggestions but looks good otherwise!

@ericpaulsen
Copy link
Member

will push the suggestions here shortly.

@ericpaulsen
Copy link
Member

@johnstcn - after speaking with @sharkymark, I decided to slim things down to only the necessary information to provision a cluster. I removed the Preliminary Steps and consolidated the Node Considerations section below the eksctl configuration file. I also removed the Access Control section as it is not immediately necessary for a Coder trial cluster.

@ericpaulsen ericpaulsen requested a review from johnstcn August 15, 2022 16:16
johnstcn
johnstcn approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I much prefer the config file approach as well to be honest!

@ericpaulsen ericpaulsen merged commit 7d7ce6e into main Aug 15, 2022
@ericpaulsen ericpaulsen deleted the install-eks-simplify-reorg branch August 15, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@ericpaulsen ericpaulsen ericpaulsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharkymark @ericpaulsen @johnstcn