chore: update az aks create invocation in azure setup docs #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #1091 deployed! It will be updated on every commit.
|
bpmct
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Looks good to me, matches the Limitations & considerations for kubenet
doc
* Cannot set `--network-policy azure` with `--network-plugin kubenet`: ``` (NetworkPolicyAzureNotSupportedForKubenet) NetworkPolicy azure is not supported for network plugin kubenet Code: NetworkPolicyAzureNotSupportedForKubenet Message: NetworkPolicy azure is not supported for network plugin kubenet Target: networkProfile.networkPolicy ``` * Must set the `--node-count` parameter equal to `--min-count` as it appears to default to 0 if unspecified.
bpmct
reviewed
Aug 29, 2022
Comment on lines
+80
to
+82
| Coder's trial license does not work in an air-gapped environment. If your | ||
| organization is interested in evaluating Coder air-gapped, please contact | ||
| [sales@coder.com](mailto:sales@coder.com) to discuss license requirements. |
There was a problem hiding this comment.
0cffb50 introduced a linter error, which was causing tests to fail
|
Rebased and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--network-policy azurewith--network-plugin kubenet:--node-countparameter equal to--min-countas it appears to default to 0 if unspecified.