Skip to content

chore: update az aks create invocation in azure setup docs #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

chore: update az aks create invocation in azure setup docs #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a099e8
chore: update az aks create invocation in azure setup docs
johnstcn Aug 19, 2022
3b9ce98
fix lint error
bpmct Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions comparison.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,6 @@ support.
> To get a free trial of Coder, please visit
> [https://coder.com/trial](https://coder.com/trial).

> Coder's trial license does not work in an air-gapped environment. If your
> organization is interested in evaluating Coder air-gapped, please contact
> [sales@coder.com](mailto:sales@coder.com) to discuss license requirements.
Coder's trial license does not work in an air-gapped environment. If your
organization is interested in evaluating Coder air-gapped, please contact
[sales@coder.com](mailto:sales@coder.com) to discuss license requirements.
Comment on lines +80 to +82
Copy link
Member

@bpmct bpmct Aug 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0cffb50 introduced a linter error, which was causing tests to fail

4 changes: 2 additions & 2 deletions setup/kubernetes/azure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ az aks create \
--location "$LOCATION" \
--max-count 10 \
--min-count 2 \
--node-count 2 \
--node-vm-size Standard_B8ms \
--network-plugin "kubenet" \
--network-policy "azure"
--network-plugin "kubenet"
```

> Both options include the
Expand Down