Skip to content

fix: make env var a string #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix: make env var a string #1115

merged 2 commits into from
Sep 7, 2022

Conversation

ericpaulsen
Copy link
Member

our docs incorrectly reference an env var as an integer rather than a string. the extraEnvs value is defined as type string in the core v1 API docs.

@ericpaulsen ericpaulsen added the bug 🐛 Something isn't working label Sep 7, 2022
@ericpaulsen ericpaulsen self-assigned this Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022 •
edited
Loading

✨ Coder.com for PR #1115 deployed! It will be updated on every commit.

@sharkymark sharkymark merged commit 191b06f into main Sep 7, 2022
@sharkymark sharkymark deleted the fix-env-string branch September 7, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkymark sharkymark sharkymark approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@ericpaulsen ericpaulsen

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpaulsen @sharkymark