Skip to content

fix: manifest.json: add v1.37 to versions array #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 26, 2022

Add missing v1.37 to versions array.
Also add a script validate-manifest to ensure that missing versions in the changelog are caught by lint-staged.
TODO: cherry to v1.37 branch edit: done

@johnstcn johnstcn self-assigned this Nov 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2022

✨ Coder.com for PR #1181 deployed! It will be updated on every commit.

@ericpaulsen
Copy link
Member

@johnstcn it's showing the commit hash instead of the version:

Screen Shot 2022-11-27 at 7 17 55 PM

@johnstcn
Copy link
Member Author

@johnstcn it's showing the commit hash instead of the version:

Screen Shot 2022-11-27 at 7 17 55 PM

I believe that's normal on preview.

@johnstcn johnstcn merged commit aa7fe91 into main Nov 28, 2022
@johnstcn johnstcn deleted the cj/fix-versions-137 branch November 28, 2022 11:20
johnstcn added a commit that referenced this pull request Nov 28, 2022
* fix: manifest.json: add v1.37 to versions array
* chore: add script to validate manifest versions

(cherry picked from commit aa7fe91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants