Skip to content

Remove refs to cli repo docs, move cli reference in #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2023
Merged

Remove refs to cli repo docs, move cli reference in #1234

merged 3 commits into from
Mar 13, 2023

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtis spikecurtis commented Mar 13, 2023 •
edited
Loading

@spikecurtis
Remove refs to cli repo docs, move cli reference in
621ee23 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested review from sreya, johnstcn and bpmct March 13, 2023 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

✨ Coder.com for PR #1234 deployed! It will be updated on every commit.

@spikecurtis
Add ref to manifest; fix link
b8f7f11 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis marked this pull request as ready for review March 13, 2023 11:35
johnstcn
johnstcn reviewed Mar 13, 2023
View reviewed changes
johnstcn
johnstcn approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the links work now 👍
There's just a typo in the manifest for config-ssh.

@spikecurtis @johnstcn
Update manifest.json
b62420d 
Co-authored-by: Cian Johnston <cian@coder.com>
@spikecurtis spikecurtis merged commit 13f385d into main Mar 13, 2023
@spikecurtis spikecurtis deleted the spike/13769-cli-docs branch March 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@bpmct bpmct bpmct approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @johnstcn @bpmct