Skip to content

WAC release fixups #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021
Merged

WAC release fixups #230

merged 2 commits into from
Mar 31, 2021

Conversation

lilshoff
Copy link
Contributor

Primary issue:
The sample template has an incorrect structure for configure

Secondary issue:
Inconsistent use of periods at the end of bullet points 🤷

@github-actions
Copy link
Contributor

✨ Coder.com for PR #230 deployed! It will be updated on every commit.

Copy link
Contributor

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it 🙂

@lilshoff lilshoff merged commit 070d0f0 into master Mar 31, 2021
@lilshoff lilshoff deleted the lilshoff/wac-release-fixups branch March 31, 2021 18:53
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@greyscaled
Copy link
Contributor

@all-contributors please thank @lilshoff for bug, content

@allcontributors
Copy link
Contributor

@vapurrmaid

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@greyscaled
Copy link
Contributor

@all-contributors please add @lilshoff for bug, content

@allcontributors
Copy link
Contributor

@vapurrmaid

I've put up a pull request to add @lilshoff! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants