-
Notifications
You must be signed in to change notification settings - Fork 81
Update air-gapped / offline installation #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request has been linked to Clubhouse Story #10080: Remove deploy/offline/README.md and reference docs/setup/offline.md instead . |
✨ Coder.com for PR #237 deployed! It will be updated on every commit.
|
setup/air-gapped.md
Outdated
needs to so a certificate issue will prevent adding images. If a certificate | ||
authority is present in the network, the root certificate may need to be added | ||
this way. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by this paragraph; are you saying that Coder validates images and pulls tags via API so if there are certificate issues, these two things might not happen? Then, to fix, the user might need to add the root cert?
setup/air-gapped.md
Outdated
kubectl -n coder create secret generic local-registry-cert --from-file=/certs | ||
``` | ||
|
||
If the `-out` argument on the OpenSSL command to generate the certificates was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used -keyout, but I'm assuming this still applies?
FYI I'm in the middle of splitting this into two docs; the current air-gap doc will be mostly the same with the infra stuff on its own. |
@mterhar @ericpaulsen (Eric, I'm tagging you since I think you have experience with this?) -- I split this into to docs and moved some stuff around based on where I thought things made sense. I also had some questions, so hopefully, you could provide additional guidance? |
8804e12
to
c62f131
Compare
@khorne3 may want to revet my last commit. I think it was misguided to undo the second-person. |
Reduced second-person and upgraded the tone
e1f01f7
to
6d4f7b1
Compare
After going through the process, many items seem relevant that were omitted. There's an argument to be made that the majority of what I'm suggesting here is out of scope for docs and may do better in Guides. I'm happy to have that discussion and move things around, but I wanted to get the draft ironed out while it was fresh.
[ch10080]