This repository was archived by the owner on Aug 18, 2025. It is now read-only.
add: Cloud DNS SSL config #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpaulsen
commented
Apr 12, 2021
|
|
||
| You must have: | ||
|
|
||
| - A Kubernetes cluster with internet connectivity |
There was a problem hiding this comment.
cert-manager supports 1.16+ K8s versions, but I could not find any Cloud DNS-specific version compatibilities. This doc also assumes that a customer has a Service Account configured.
ericpaulsen
commented
Apr 12, 2021
| - A | ||
| [Service Account](https://cloud.google.com/iam/docs/creating-managing-service-accounts) | ||
|
|
||
| ## Step 1: Add cert-manager to your Kubernetes cluster |
There was a problem hiding this comment.
If needed, feel free to add context around applying the cert-manager manifest.
ericpaulsen
commented
Apr 12, 2021
|
✨ Coder.com for PR #269 deployed! It will be updated on every commit.
|
bpmct
previously requested changes
Apr 13, 2021
There was a problem hiding this comment.
This is awesome Eric!
I think this also needs to be added to the manifest.json so that it is added in https://codercom-2h12dwib3-codercom.vercel.app/docs/guides/ssl-certificates
khorne3
approved these changes
Apr 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding steps for configuring SSL for Coder via Google's Cloud DNS, referenced from this doc.
i've completed a successful install for a customer using the linked doc, but it wouldn't hurt for someone else to dogfood it.
please see my comments below for line-specific thoughts.