Skip to content

chore: add Action to check for old files #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021
Merged

chore: add Action to check for old files #277

merged 3 commits into from
Apr 15, 2021

Conversation

khorne3
Copy link
Contributor

@khorne3 khorne3 commented Apr 15, 2021

No description provided.

@github-actions github-actions bot requested a deployment to codercom-preview-docs April 15, 2021 17:49 Pending
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2021

✨ Coder.com for PR #277 deployed! It will be updated on every commit.

Copy link
Contributor

@IAmHughes IAmHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we got that working! This does include all the dirs we want to check, right?

id: old_files
with:
minAge: 60
dirs: '["admin", "cli", "environments", "guides", "images", "setup"]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly believe that it may make sense to use dirs: '["."]' if that works, as I can see this getting out of date easily.

The other solution is to move all documentation into a root dir:

docs/
  admin/
  cli/

I won't request that change now as to keep us unblocked, but think we should switch soon

Copy link
Contributor

@greyscaled greyscaled Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we got that working! This does include all the dirs we want to check, right?

@IAmHughes - my proposal is we move all released MD files into a root path of its own (ex: docs/), as then this is a non-issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dirs: '["."]' worked perfectly so I did that

@khorne3 khorne3 merged commit e737a64 into master Apr 15, 2021
@khorne3 khorne3 deleted the stale-docs branch April 15, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants