-
Notifications
You must be signed in to change notification settings - Fork 81
chore: add Action to check for old files #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Coder.com for PR #277 deployed! It will be updated on every commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad we got that working! This does include all the dirs we want to check, right?
.github/workflows/ci.yaml
Outdated
id: old_files | ||
with: | ||
minAge: 60 | ||
dirs: '["admin", "cli", "environments", "guides", "images", "setup"]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly believe that it may make sense to use dirs: '["."]'
if that works, as I can see this getting out of date easily.
The other solution is to move all documentation into a root dir:
docs/
admin/
cli/
I won't request that change now as to keep us unblocked, but think we should switch soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad we got that working! This does include all the dirs we want to check, right?
@IAmHughes - my proposal is we move all released MD files into a root path of its own (ex: docs/
), as then this is a non-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dirs: '["."]'
worked perfectly so I did that
No description provided.