-
Notifications
You must be signed in to change notification settings - Fork 81
add port table #284
add port table #284
Conversation
✨ Coder.com for PR #284 deployed! It will be updated on every commit.
|
@ericpaulsen Yeah, markdown tables aren't nice at all. I'll turn your screenshot into a table soon. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me provided that @khorne3 converts the image into a table :)
Awesome! I'll leave this PR open so you can push a commit with the table under this branch. |
</tr> | ||
<tr> | ||
<td rowspan="4">cemanager</td> | ||
<td>loadbalancer</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f0ssel should we use LoadBalancer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked cdr/m -- it's super inconsistent, but we should capitalize it the way it appears to the user
adding this chart of all ports related to Coder resources. we've recently sent this to a couple of customers who wanted to hardwire their own network policies, so I thought it'd be helpful to be in docs for future cases.
initially, I intended on creating a markdown table replica of the chart, but had a hard time nesting multiple rows in the larger parent columns... so I just included the screenshot for PR to get this started. if someone could help me make one or add it themselves, I think it would look a bit cleaner.
including @f0ssel & @jawnsy to validate and add context if necessary.