feat: connecting an external postgres #302
Conversation
|
✨ Coder.com for PR #302 deployed! It will be updated on every commit.
|
There was a problem hiding this comment.
I'll leave others to review grammar but content-wise this seems ok. I think for this guide to be valuable it should mainly be about how to setup a Postgres instance. We already have documentation for how to reference postgres in the helm here on step 4.
guides/deployments/postgres.md
Outdated
| ```console | ||
| kubectl create secret generic <YOUR-DB-SECRET> \ | ||
| --from-literal=password=<YOUR-DATABASE-PASSWORD> \ | ||
| ``` |
There was a problem hiding this comment.
This is fine but we should encourage people to create passwords in a way where the secret isn't recorded in your shell history. For example this is a more security-conscious way to create a secret on the cmd line
kubectl create secret generic <NAME> --from-file=test=/dev/stdinThere was a problem hiding this comment.
I can update the sample command in Step 4.
guides/deployments/postgres.md
Outdated
| deployments, and hosting it external to the cluster. Below are the steps to do | ||
| so: | ||
|
|
||
| 1. Spin up a PostgreSQL instance if you have not already done so |
There was a problem hiding this comment.
This step should be the bulk of the guide. This page does not otherwise provide much beyond the existing documentation for referencing a postgres instance in the helm.
Good point - since there are many ways someone can setup a postgres, should we focus on documenting how to set up a postgres within each cloud provider? |
|
@ericpaulsen Do you think it makes sense to link to the tutorials instead (e.g., GKE's PostgreSQL docs)? |
Yes, as long as we include links for each of the 3 major cloud providers. |
adding docs for hooking up an external (to the cluster) postgres, as it is our recommended approach for production Coder deployments.
this is intended as an MVP, as I expect us to iterate on this as we continue to get customer feedback. open to thoughts & suggestions.