Explain install.sh must be executable #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a sentence explaining that the install.sh must be marked executable and that coder won't do it for you.
IAmHughes
previously requested changes
May 4, 2021
There was a problem hiding this comment.
@brianbegy thank you for your contribution! I added a small suggestion below.
@khorne3 let me know if you prefer this format. I think we should at least put install.sh in code tags but I'm not convinced on the Note prefix I added
Accept suggestion from review. Co-authored-by: Thomas Hughes <2894107+IAmHughes@users.noreply.github.com>
khorne3
approved these changes
May 4, 2021
|
@all-contributors please add @brianbegy for content |
|
I've put up a pull request to add @brianbegy! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sentence explaining that the install.sh must be marked executable and that coder won't do it for you.
I was assuming that coder would mark as executable anything it intended to execute. That is not the case.