Fix helm variable names in CloudDNS docs #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in variable name (`ingress.tls.devurlsHostSecretName`) and change variable value from array to object (`ingress.annotations`).
bpmct
approved these changes
May 17, 2021
There was a problem hiding this comment.
Thanks for the contribution, much appreciated!
for other reviewers: correct casing can be verified here: https://github.com/cdr/enterprise-helm/search?q=devurlshostsecretname
ericpaulsen
approved these changes
May 17, 2021
khorne3
approved these changes
May 17, 2021
|
@all-contributors please add @xbaun for bug, content |
|
I've put up a pull request to add @xbaun! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in variable name (
ingress.tls.devurlsHostSecretName) and change variable value from array to object (ingress.annotations).