In order to test that your change takes effect, you will also need to modify this line to check out your branch: https://github.com/cdr/docs/pull/402/files#diff-22da830e02ef5bed54ecad981722fd9c940aec797740c09927d4a904df0bccd6L20

You should be able to check the deployment log for the preview build and verify that Vercel emits the message the variable being overridden

Sorry, I did not understand this "In order to test that your change takes effect, you will also need to modify this line to check out your branch:".

This workflow works by cloning the monorepo's default branch (master), patching the docs submodule, and then deploying the monorepo and coder.com site to Vercel. Since you didn't modify the line that I referenced, it's cloning from master and you're not testing your changes.

In order to test your changes, you will need to change the reference that it checks out to be the branch in the monorepo that you made your changes on. Otherwise, this just shows that adding the environment variable doesn't break the existing build.

Ahhh ok, I gotcha. I will merge the new docs on master soon - any time today. So we can keep it as it is I think.

@jawnsy do you think we could merge this?

go for it :)