fix: helm variable names, annotations for AzureDNS & Route 53 #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #408 deployed! It will be updated on every commit.
|
khorne3
approved these changes
Jun 15, 2021
mterhar
reviewed
Jun 15, 2021
guides/ssl-certificates/azureDNS.md
Outdated
| --set ingress.annotations.cert-manager\.io/cluster-issuer=letsencrypt \ | ||
| --set ingress.tls.devurlsHostSecretName=coder-devurls-cert \ | ||
| --set ingress.tls.hostSecretName=coder-root-cert \ | ||
| --set ingress.annotations.cert-manager\.io/cluster-issuer="letsencrypt" \ |
There was a problem hiding this comment.
Suggested change
| --set ingress.annotations.cert-manager\.io/cluster-issuer="letsencrypt" \ | |
| --set ingress.annotations."cert-manager\.io/cluster-issuer"="letsencrypt" \ |
Add quotes around the dot that has been creating issues.
mterhar
reviewed
Jun 15, 2021
guides/ssl-certificates/route53.md
Outdated
| --set ingress.annotations.cert-manager\.io/cluster-issuer=letsencrypt \ | ||
| --set ingress.tls.devurlsHostSecretName=coder-devurls-cert \ | ||
| --set ingress.tls.hostSecretName=coder-root-cert \ | ||
| --set ingress.annotations.cert-manager\.io/cluster-issuer="letsencrypt" \ |
There was a problem hiding this comment.
Suggested change
| --set ingress.annotations.cert-manager\.io/cluster-issuer="letsencrypt" \ | |
| --set ingress.annotations."cert-manager\.io/cluster-issuer"="letsencrypt" \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same variable change as done in #348, while also adding quotations to the letsencrypt annotation.