chore: use minimal permissions for workflows #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict the GITHUB_TOKEN issued for builds to reads of respository metadata and file contents.
greyscaled
suggested changes
Jun 21, 2021
There was a problem hiding this comment.
Nice change! Unfortunately we're seeing this now:
https://github.com/cdr/docs/pull/422/checks?check_run_id=2865230382#step:10:15
|
Ah good call, I was changing repo settings at the same time and broke that one, should be fixed now:
|
|
It looks like we'll need more permissions for the specified actions?
|
|
Yeah, might need write access to pull_requests 🤔 will try that next |
jawnsy
commented
Jun 21, 2021
|
✨ Coder.com for PR #422 deployed! It will be updated on every commit.
|
khorne3
approved these changes
Jun 21, 2021
greyscaled
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict the GITHUB_TOKEN issued for builds to reads of respository
metadata and file contents.