custom images: clarify building CVM images #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #452 deployed! It will be updated on every commit.
|
ericpaulsen
approved these changes
Jun 29, 2021
khorne3
approved these changes
Jun 30, 2021
jawnsy
reviewed
Jun 30, 2021
images/writing.md
Outdated
| @@ -7,8 +7,8 @@ Custom images allow you to define workspaces that include the dependencies, | |||
| scripts, and user preferences helpful for your project. | |||
|
|
|||
| > If you're unfamiliar with how to create, build, and push Docker Images, please | |||
| > review | |||
| > [this tutorial by Docker](http://blog.shippable.com/build-a-docker-image-and-push-it-to-docker-hub) | |||
| > review [this tutorial by | |||
There was a problem hiding this comment.
the label implies that Docker Inc wrote this, but the post is by a different company?
The link also appears to be dead
There was a problem hiding this comment.
Updating to link to docs; unfortunately, the blog is having some CDN issues (I think) but we don't want to rely on them despite this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: