Skip to content

local preview: add instructions for dev urls #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 19, 2021
Merged

local preview: add instructions for dev urls #483

merged 8 commits into from
Jul 19, 2021

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Jul 12, 2021

add instructions for running dev urls with the local preview.

significant changes:

  • runs local preview script to install on port 80 instead of 8080 (necessary for dev urls)
  • dev urls is documented as optional as it requires more work and not necessary (ngrok remains an option)
  • for dev urls, added a recommendation for nip.io or dnsmasq to add a wildcard subdomain for Dev URLs

teardown guide for dnsmasq is included

@bpmct bpmct requested review from sharkymark, coadler and khorne3 July 12, 2021 16:54
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2021 •
edited
Loading

✨ Coder.com for PR #483 deployed! It will be updated on every commit.

@bpmct
Copy link
Member Author

bpmct commented Jul 12, 2021

[ch14942]

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #14942: local preview: document dev url options.

coadler
coadler reviewed Jul 12, 2021
View reviewed changes
coadler
coadler reviewed Jul 12, 2021
View reviewed changes
@bpmct bpmct requested a review from coadler July 12, 2021 20:31
jawnsy
jawnsy reviewed Jul 13, 2021
View reviewed changes
jawnsy
jawnsy reviewed Jul 13, 2021
View reviewed changes
bpmct
bpmct commented Jul 14, 2021
View reviewed changes
@khorne3 khorne3 merged commit bff0e40 into main Jul 19, 2021
@khorne3 khorne3 deleted the kind-devurls branch July 19, 2021 14:51
khorne3 added a commit that referenced this pull request Jul 19, 2021
@khorne3
Revert "local preview: add instructions for dev urls (#483)"
91bcf5a 
This reverts commit bff0e40.
@khorne3 khorne3 mentioned this pull request Jul 19, 2021
Merged
khorne3 pushed a commit that referenced this pull request Jul 19, 2021
Revert "local preview: add instructions for dev urls (#483)" (#495)
fc323cd 
This reverts commit bff0e40.
@khorne3
Copy link
Contributor

khorne3 commented Jul 19, 2021

@BrunoQuaresma this is the PR that broke the build. is it possible to get increased logging for instances such as this (whatever the problem may be)?

@BrunoQuaresma BrunoQuaresma restored the kind-devurls branch July 19, 2021 16:27
@BrunoQuaresma
Copy link
Contributor

@khorne3 from the logs, the error is:

Unknown language: `conf` is not registered

@BrunoQuaresma
Copy link
Contributor

BrunoQuaresma commented Jul 19, 2021 •
edited
Loading

Probably, related to this:

conf
   # coder.conf
   address=/coder/127.0.0.1

at https://github.com/cdr/docs/pull/483/files#diff-ce83bb24bce6abad1b382779341a39e1537ac76c065b6b6a39d8d4b0fe972058R152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawnsy jawnsy jawnsy left review comments

@coadler coadler coadler approved these changes

@khorne3 khorne3 khorne3 approved these changes

@sharkymark sharkymark Awaiting requested review from sharkymark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bpmct @khorne3 @BrunoQuaresma @jawnsy @coadler