This repository was archived by the owner on Aug 18, 2025. It is now read-only.
cloud DNS docs: fix outdated dns01 solver name #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Was in the process of making this change myself. |
ericpaulsen
approved these changes
Aug 2, 2021
|
✨ Coder.com for PR #530 deployed! It will be updated on every commit.
|
khorne3
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The current docs do not work for someone using the version of cert manager we recommend. I ran into this while testing the cloud DNS docs on a new cluster
The old version we used to recommend works fine.
https://github.com/streamnative/charts/pull/135/files#diff-f446351342bdec56ed4dcd24f2fce3d14fee4c3c50c3bf92e07637b3fac885acL41-L42