fix(workspaces): add and arrange missing env vars #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #643 deployed! It will be updated on every commit.
|
jawnsy
reviewed
Oct 1, 2021
4c46a98 to
6f7cf8d
Compare
jawnsy
reviewed
Oct 18, 2021
khorne3
reviewed
Oct 18, 2021
workspaces/variables.md
Outdated
| <tr> | ||
| <td><code>CODER_ASSETS_ROOT</code></td> | ||
| <td>The directory where coder adds coder-specific assets during | ||
| workspace creation, such as the coder-cli binary</td> |
There was a problem hiding this comment.
Suggested change
| workspace creation, such as the coder-cli binary</td> | |
| workspace creation, such as the `coder-cli` binary</td> |
There was a problem hiding this comment.
I think we'll have to use <code> wrappers here since this part is within a <td>
There was a problem hiding this comment.
pushed in dc86f04 - will need to check preview
Co-authored-by: Katie Horne <katie@coder.com>
khorne3
approved these changes
Oct 19, 2021
|
Thanks for the added commits @khorne3 🎉 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fill in the details of a few of them. Arranged them to match the output given by